[
https://issues.apache.org/jira/browse/KAFKA-15341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17787595#comment-17787595
]
Phuc Hong Tran commented on KAFKA-15341:
----------------------------------------
[~showuon] [~satish.duggana], just to clarify, the situation that we are
discussing it about when we need to enable TS system wide, but not all brokers
have TS enable on them. This could mean that those brokers don't have the
"{_}remote.log.storage.system.enable"{_} set to true, or they haven't undergone
restart yet, meaning their metadata version is less then what is required for
TS. That mean we need to have the MetadataVersion.java updated to check if a
metadata version support TS or not, and also send some data about whether a
broker has "{_}remote.log.storage.system.enable"{_} set to true or not, since
the default value of this property is false. That also mean we will need to
update broker's metadata format, specifically broker registration record to
have the enable TS status of a broker. Do you guys think we need a KIP for this
since we're changing the broker's metadata format?
> Enabling TS for a topic during rolling restart causes problems
> --------------------------------------------------------------
>
> Key: KAFKA-15341
> URL: https://issues.apache.org/jira/browse/KAFKA-15341
> Project: Kafka
> Issue Type: Bug
> Reporter: Divij Vaidya
> Assignee: Phuc Hong Tran
> Priority: Major
> Labels: KIP-405
> Fix For: 3.7.0
>
>
> When we are in a rolling restart to enable TS at system level, some brokers
> have TS enabled on them and some don't. We send an alter config call to
> enable TS for a topic, it hits a broker which has TS enabled, this broker
> forwards it to the controller and controller will send the config update to
> all brokers. When another broker which doesn't have TS enabled (because it
> hasn't undergone the restart yet) gets this config change, it "should" fail
> to apply it. But failing now is too late since alterConfig has already
> succeeded since controller->broker config propagation is done async.
> With this JIRA, we want to have controller check if TS is enabled on all
> brokers before applying alter config to turn on TS for a topic.
> Context: https://github.com/apache/kafka/pull/14176#discussion_r1291265129
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
