lianetm commented on code in PR #14690:
URL: https://github.com/apache/kafka/pull/14690#discussion_r1396462214
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##########
@@ -843,7 +845,11 @@ private void updatePatternSubscription(Cluster cluster) {
@Override
public void unsubscribe() {
Review Comment:
I updated it to align with the current behaviour (callbacks, best effort to
send leave group request without any response handling or retry, and call to
`subscriptions.unsubscribe` when everything completes). This has the gap of the
callback execution that would require a poll. Given that we don't support
callbacks in this PR, it won't block the flow, but definitely to be solved (I
added the details of the challenge to solve in the [callbacks
Jira](https://issues.apache.org/jira/browse/KAFKA-15276))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
