cmccabe commented on code in PR #14719:
URL: https://github.com/apache/kafka/pull/14719#discussion_r1394828896
##########
core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala:
##########
@@ -376,6 +436,24 @@ class ZkMetadataCache(
// This method returns the deleted TopicPartitions received from
UpdateMetadataRequest
def updateMetadata(correlationId: Int, updateMetadataRequest:
UpdateMetadataRequest): Seq[TopicPartition] = {
inWriteLock(partitionMetadataLock) {
+ if (updateMetadataRequest.updateType() ==
AbstractControlRequest.Type.FULL) {
+ if (updateMetadataRequest.version() < 8) {
Review Comment:
Seems a bit weird to check this. Doesn't the schema prevent this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
