artemlivshits commented on code in PR #14753:
URL: https://github.com/apache/kafka/pull/14753#discussion_r1392946436
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -813,7 +813,8 @@ class ReplicaManager(val config: KafkaConfig,
recordConversionStatsCallback,
timeout,
responseCallback,
- delayedProduceLock
+ delayedProduceLock,
+ actionQueue
Review Comment:
Wow, this is so subtle, I stared at the change for some time to understand
what it actually does; it's almost impossible to spot in the code review and
the compiler cannot help either, what can we do to catch these issues in the
future? I think we should rename the member variable to be something like
`defaultActionQueue` so that if we don't pass the `actionQueue` the compiler
would catch it.
Another question (probably to @dajac) -- is passing the `actionQueue` in the
argument just an optimization or a correctness issue? If it's just an
optimization, I wonder what would be the effects of removing it and reduce the
overall system complexity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
