cmccabe commented on code in PR #14369:
URL: https://github.com/apache/kafka/pull/14369#discussion_r1391771537
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -2323,15 +2326,56 @@ class ReplicaManager(val config: KafkaConfig,
}
logManager.handleLogDirFailure(dir)
- if (sendZkNotification)
+ if (notifyController) {
+ if (config.migrationEnabled) {
+ fatal(s"Shutdown broker because some log directory has failed during
migration mode: $dir")
+ Exit.halt(1)
Review Comment:
This seems wrong as our long-term solution, but I guess it's OK for now. (We
can discuss more later I guess)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
