dajac commented on code in PR #14635:
URL: https://github.com/apache/kafka/pull/14635#discussion_r1388489571
##########
clients/src/test/java/org/apache/kafka/common/requests/LeaveGroupResponseTest.java:
##########
@@ -165,4 +169,55 @@ public void testEqualityWithMemberResponses() {
assertEquals(primaryResponse.hashCode(),
reversedResponse.hashCode());
}
}
+
+ @ParameterizedTest
+ @ApiKeyVersionsSource(apiKey = ApiKeys.LEAVE_GROUP)
+ public void testNoErrorNoMembersResponses(short version) {
+ LeaveGroupResponseData data = new LeaveGroupResponseData()
+ .setErrorCode(Errors.NONE.code())
+ .setMembers(Collections.emptyList());
+
+ if (version < 3) {
+ assertThrows(UnsupportedVersionException.class,
+ () -> new LeaveGroupResponse(data, version));
+ } else {
+ LeaveGroupResponse response = new LeaveGroupResponse(data,
version);
+ assertEquals(Errors.NONE, response.topLevelError());
Review Comment:
nit: Should we also assert the members here?
##########
clients/src/test/java/org/apache/kafka/common/requests/LeaveGroupResponseTest.java:
##########
@@ -165,4 +169,55 @@ public void testEqualityWithMemberResponses() {
assertEquals(primaryResponse.hashCode(),
reversedResponse.hashCode());
}
}
+
+ @ParameterizedTest
+ @ApiKeyVersionsSource(apiKey = ApiKeys.LEAVE_GROUP)
+ public void testNoErrorNoMembersResponses(short version) {
+ LeaveGroupResponseData data = new LeaveGroupResponseData()
+ .setErrorCode(Errors.NONE.code())
+ .setMembers(Collections.emptyList());
+
+ if (version < 3) {
+ assertThrows(UnsupportedVersionException.class,
+ () -> new LeaveGroupResponse(data, version));
+ } else {
+ LeaveGroupResponse response = new LeaveGroupResponse(data,
version);
+ assertEquals(Errors.NONE, response.topLevelError());
+ }
+ }
+
+ @ParameterizedTest
+ @ApiKeyVersionsSource(apiKey = ApiKeys.LEAVE_GROUP)
+ public void testNoErrorMultipleMembersResponses(short version) {
+ LeaveGroupResponseData data = new LeaveGroupResponseData()
+ .setErrorCode(Errors.NONE.code())
+ .setMembers(memberResponses);
+
+ if (version < 3) {
+ assertThrows(UnsupportedVersionException.class,
+ () -> new LeaveGroupResponse(data, version));
Review Comment:
nit: Could we also intend this one with 4 spaces?
##########
clients/src/test/java/org/apache/kafka/common/requests/LeaveGroupResponseTest.java:
##########
@@ -165,4 +169,55 @@ public void testEqualityWithMemberResponses() {
assertEquals(primaryResponse.hashCode(),
reversedResponse.hashCode());
}
}
+
+ @ParameterizedTest
+ @ApiKeyVersionsSource(apiKey = ApiKeys.LEAVE_GROUP)
+ public void testNoErrorNoMembersResponses(short version) {
+ LeaveGroupResponseData data = new LeaveGroupResponseData()
+ .setErrorCode(Errors.NONE.code())
+ .setMembers(Collections.emptyList());
+
+ if (version < 3) {
+ assertThrows(UnsupportedVersionException.class,
+ () -> new LeaveGroupResponse(data, version));
Review Comment:
nit: Could we indent this line with 4 spaces in order to remain consistent
with the existing code?
##########
clients/src/test/java/org/apache/kafka/common/requests/LeaveGroupResponseTest.java:
##########
@@ -165,4 +169,55 @@ public void testEqualityWithMemberResponses() {
assertEquals(primaryResponse.hashCode(),
reversedResponse.hashCode());
}
}
+
+ @ParameterizedTest
+ @ApiKeyVersionsSource(apiKey = ApiKeys.LEAVE_GROUP)
+ public void testNoErrorNoMembersResponses(short version) {
+ LeaveGroupResponseData data = new LeaveGroupResponseData()
+ .setErrorCode(Errors.NONE.code())
+ .setMembers(Collections.emptyList());
+
+ if (version < 3) {
+ assertThrows(UnsupportedVersionException.class,
+ () -> new LeaveGroupResponse(data, version));
+ } else {
+ LeaveGroupResponse response = new LeaveGroupResponse(data,
version);
+ assertEquals(Errors.NONE, response.topLevelError());
+ }
+ }
+
+ @ParameterizedTest
+ @ApiKeyVersionsSource(apiKey = ApiKeys.LEAVE_GROUP)
+ public void testNoErrorMultipleMembersResponses(short version) {
+ LeaveGroupResponseData data = new LeaveGroupResponseData()
+ .setErrorCode(Errors.NONE.code())
+ .setMembers(memberResponses);
+
+ if (version < 3) {
+ assertThrows(UnsupportedVersionException.class,
+ () -> new LeaveGroupResponse(data, version));
+ } else {
+ LeaveGroupResponse response = new LeaveGroupResponse(data,
version);
+ assertEquals(Errors.NONE, response.topLevelError());
Review Comment:
nit: Should we also assert members here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
