jolshan commented on code in PR #14721:
URL: https://github.com/apache/kafka/pull/14721#discussion_r1388376812
##########
core/src/main/scala/kafka/utils/PasswordEncoder.scala:
##########
@@ -130,7 +131,7 @@ class EncryptingPasswordEncoder(
val decrypted = cipher.doFinal(encryptedPassword)
new String(decrypted, StandardCharsets.UTF_8)
} catch {
- case e: Exception => throw new ConfigException("Password could not be
decoded", e)
+ case e: Exception => throw new InvalidConfigurationException("Password
could not be decoded", e)
Review Comment:
took a quick look at usages -- looks like dynamic broker configs where it is
caught and handled and the ZK migration code that doesn't seeme to specifically
handle either error case. I feel ok with this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
