soarez commented on code in PR #14369:
URL: https://github.com/apache/kafka/pull/14369#discussion_r1386609951
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -2296,13 +2298,41 @@ class ReplicaManager(val config: KafkaConfig,
if (sendZkNotification)
if (zkClient.isEmpty) {
- warn("Unable to propagate log dir failure via Zookeeper in KRaft mode")
+ val uuid = logManager.directoryId(dir)
+ if (uuid.isDefined && lifecycleManager.isDefined)
+ lifecycleManager.get.propagateDirectoryFailure(uuid.get)
Review Comment:
I think I'm missing something, why can this only happen during migration?
AFAICT this will be called in normal KRaft operation, as long as the line
`logManager.handleLogDirFailure(dir)` above does not shutdown the broker due to
there being no remaining online directories.
We did agree the broker should fail if a directory fails during migration,
apologies, I wasn't planning on making that change as part of this PR but I can
look into detecting the migration case and addressing that here too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
