jolshan commented on code in PR #14444:
URL: https://github.com/apache/kafka/pull/14444#discussion_r1384250206
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -562,6 +562,26 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
+ case class LeaderNode(leaderId: Int, leaderEpoch: Int, node: Node)
+
+ private def getCurrentLeader(tp: TopicPartition, ln: ListenerName):
LeaderNode = {
+ val partitionInfoOrError = replicaManager.getPartitionOrError(tp)
Review Comment:
Do we know how this error will be handled? I think if we throw something
during request handling we catch it in KafkaApis, but just wanted to confirm
that is done here in a way that makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
