lianetm commented on code in PR #14690:
URL: https://github.com/apache/kafka/pull/14690#discussion_r1383983917
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##########
@@ -676,12 +678,12 @@ public ConsumerGroupMetadata groupMetadata() {
@Override
public void enforceRebalance() {
- throw new KafkaException("method not implemented");
+ log.warn("Operation not supported in new consumer group protocol");
}
@Override
public void enforceRebalance(String reason) {
- throw new KafkaException("method not implemented");
+ log.warn("Operation not supported in new consumer group protocol");
Review Comment:
The KIP states that we should do exactly this, and actually the consumer
would stay functional.
`Consumer#enforceRebalance will be deprecated and will be a no-op if used
when the new protocol is enable. A warning will be logged in this case.`
Do you have a concern that I may be missing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
