vamossagar12 commented on code in PR #14432:
URL: https://github.com/apache/kafka/pull/14432#discussion_r1383610866
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -829,20 +885,49 @@ private
CoordinatorResult<ConsumerGroupHeartbeatResponseData, Record> consumerGr
// Get or create the member.
if (memberId.isEmpty()) memberId = Uuid.randomUuid().toString();
- final ConsumerGroupMember member =
group.getOrMaybeCreateMember(memberId, createIfNotExists);
+ ConsumerGroupMember member;
+ ConsumerGroupMember existingStaticMember = null;
+ if (instanceId == null) {
+ member = group.getOrMaybeCreateMember(memberId, createIfNotExists);
+ } else {
+ existingStaticMember = group.staticMember(instanceId);
+ throwIfStaticMemberValidationFails(groupId, instanceId,
existingStaticMember, memberEpoch, memberId);
+ member = group.getOrMaybeCreateMember(memberId, createIfNotExists);
+ }
Review Comment:
I have updated the logic in line with your suggestion.
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -869,6 +954,10 @@ private
CoordinatorResult<ConsumerGroupHeartbeatResponseData, Record> consumerGr
groupId, memberId, updatedMember.subscribedTopicRegex());
bumpGroupEpoch = true;
}
+ } else {
+ if (staticMemberReplaced) {
+ records.add(newMemberSubscriptionRecord(groupId,
updatedMember));
+ }
Review Comment:
Yes, that makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
