kirktrue commented on code in PR #14670:
URL: https://github.com/apache/kafka/pull/14670#discussion_r1380717397
##########
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java:
##########
@@ -666,19 +651,6 @@ else if (newConfigs.get(VALUE_DESERIALIZER_CLASS_CONFIG)
== null)
return newConfigs;
}
- boolean maybeOverrideEnableAutoCommit() {
- Optional<String> groupId =
Optional.ofNullable(getString(CommonClientConfigs.GROUP_ID_CONFIG));
- boolean enableAutoCommit =
getBoolean(ConsumerConfig.ENABLE_AUTO_COMMIT_CONFIG);
- if (!groupId.isPresent()) { // overwrite in case of default group id
where the config is not explicitly provided
- if (!originals().containsKey(ENABLE_AUTO_COMMIT_CONFIG)) {
- enableAutoCommit = false;
- } else if (enableAutoCommit) {
- throw new
InvalidConfigurationException(ConsumerConfig.ENABLE_AUTO_COMMIT_CONFIG + "
cannot be set to true when default group id (null) is used.");
- }
- }
- return enableAutoCommit;
- }
-
Review Comment:
This is now outdated. It's back in `ConsumerConfig`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
