jolshan commented on code in PR #14387:
URL: https://github.com/apache/kafka/pull/14387#discussion_r1379393439
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorShard.java:
##########
@@ -140,7 +159,12 @@ public GroupCoordinatorShard build() {
throw new IllegalArgumentException("Time must be set.");
if (timer == null)
throw new IllegalArgumentException("Timer must be set.");
+ if (coordinatorMetrics == null)
+ throw new IllegalArgumentException("CoordinatorMetricsShard
must be set.");
Review Comment:
I noticed we check the metrics shard to ensure it is a
GroupCoordinatorMetrics shard in another file. Should we check the type sooner?
Should we also check this is the type GroupCoordinatorMetrics (also should the
error not include shard here)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
