dajac commented on code in PR #14642:
URL: https://github.com/apache/kafka/pull/14642#discussion_r1374963674
##########
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java:
##########
@@ -610,6 +628,18 @@ public class ConsumerConfig extends AbstractConfig {
DEFAULT_ALLOW_AUTO_CREATE_TOPICS,
Importance.MEDIUM,
ALLOW_AUTO_CREATE_TOPICS_DOC)
+ .define(GROUP_PROTOCOL_CONFIG,
+ Type.STRING,
+ DEFAULT_GROUP_PROTOCOL,
+ ConfigDef.CaseInsensitiveValidString
+
.in(Utils.enumOptions(GroupProtocol.class)),
+ Importance.HIGH,
+ GROUP_PROTOCOL_DOC)
+ .define(REMOTE_ASSIGNOR_CONFIG,
+ Type.STRING,
+ DEFAULT_REMOTE_ASSIGNOR,
+ Importance.MEDIUM,
+ REMOTE_ASSIGNOR_DOC)
Review Comment:
@philipnee It would be better to update the new code to follow the existing
style. This is what we usually do…
##########
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java:
##########
@@ -610,6 +628,18 @@ public class ConsumerConfig extends AbstractConfig {
DEFAULT_ALLOW_AUTO_CREATE_TOPICS,
Importance.MEDIUM,
ALLOW_AUTO_CREATE_TOPICS_DOC)
+ .define(GROUP_PROTOCOL_CONFIG,
+ Type.STRING,
+ DEFAULT_GROUP_PROTOCOL,
+ ConfigDef.CaseInsensitiveValidString
+
.in(Utils.enumOptions(GroupProtocol.class)),
+ Importance.HIGH,
+ GROUP_PROTOCOL_DOC)
+ .define(REMOTE_ASSIGNOR_CONFIG,
+ Type.STRING,
+ DEFAULT_REMOTE_ASSIGNOR,
+ Importance.MEDIUM,
+ REMOTE_ASSIGNOR_DOC)
Review Comment:
@philipnee It would be better to update the new code to follow the existing
style. This is what we usually do…
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
