CalvinConfluent commented on code in PR #14593: URL: https://github.com/apache/kafka/pull/14593#discussion_r1369012157
########## metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java: ########## @@ -93,6 +93,9 @@ public enum Election { private boolean eligibleLeaderReplicasEnabled; private int minISR; + // Whether allow electing last known leader when ELR is enabled. Note, the last known leader will be stored in the + // lastKnownElr field. + private boolean lastKnownLeaderEnabled = true; Review Comment: This is mainly to save the current progress of how to correctly populate the lastKnownElr. It should be set to false if log inspection recovery is ready. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org