nizhikov commented on code in PR #14610:
URL: https://github.com/apache/kafka/pull/14610#discussion_r1368160386
##########
core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala:
##########
@@ -110,13 +110,16 @@ object ConsumerGroupCommand extends Logging {
}
def printOffsetsToReset(groupAssignmentsToReset: Map[String,
Map[TopicPartition, OffsetAndMetadata]]): Unit = {
- if (groupAssignmentsToReset.nonEmpty)
- println("\n%-30s %-30s %-10s %-15s".format("GROUP", "TOPIC",
"PARTITION", "NEW-OFFSET"))
+ val format = "%-30s %-30s %-10s %-15s"
+ if (groupAssignmentsToReset.nonEmpty) {
+ println()
Review Comment:
> Why not move this println() to format？ So is the one below.
Done.
##########
core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala:
##########
@@ -110,13 +110,16 @@ object ConsumerGroupCommand extends Logging {
}
def printOffsetsToReset(groupAssignmentsToReset: Map[String,
Map[TopicPartition, OffsetAndMetadata]]): Unit = {
- if (groupAssignmentsToReset.nonEmpty)
- println("\n%-30s %-30s %-10s %-15s".format("GROUP", "TOPIC",
"PARTITION", "NEW-OFFSET"))
+ val format = "%-30s %-30s %-10s %-15s"
+ if (groupAssignmentsToReset.nonEmpty) {
+ println()
Review Comment:
> Why not move this println() to format？ So is the one below.
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
