jeel2420 commented on code in PR #14483:
URL: https://github.com/apache/kafka/pull/14483#discussion_r1366846188
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##########
@@ -151,9 +151,8 @@ private Cache<Uuid, Entry> initEmptyCache(long maxSize) {
.weigher((Uuid key, Entry entry) -> {
return (int) entry.entrySizeBytes;
})
- // removeListener is invoked when either the entry is
invalidated (means manual removal by the caller) or
- // evicted (means removal due to the policy)
- .removalListener((Uuid key, Entry entry, RemovalCause cause)
-> {
+ // evictionListener is invoked when RemovalCause.wasEvicted()
is true
Review Comment:
Done
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##########
@@ -187,7 +186,18 @@ public File cacheDir() {
public void remove(Uuid key) {
lock.readLock().lock();
try {
- internalCache.invalidate(key);
+ internalCache.asMap().computeIfPresent(key, (k, v) -> {
+ try {
+ v.markForCleanup();
+ if (!expiredIndexes.offer(v)) {
+ log.error("Error while inserting entry {} for key {}
into the cleaner queue because queue is full.", v, k);
+ }
+ } catch (IOException e) {
+ throw new KafkaException(e);
+ }
+ // Returning null to remove the key from the cache
+ return null;
+ });
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
