cmccabe commented on code in PR #14545:
URL: https://github.com/apache/kafka/pull/14545#discussion_r1366013492
##########
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationZkWriter.java:
##########
@@ -146,6 +147,15 @@ void handleTopicsSnapshot(TopicsImage topicsImage,
KRaftMigrationOperationConsum
Map<Uuid, Map<Integer, PartitionRegistration>> changedPartitions = new
HashMap<>();
Map<Uuid, Map<Integer, PartitionRegistration>> newPartitions = new
HashMap<>();
+ Set<String> pendingTopicDeletions =
migrationClient.topicClient().readPendingTopicDeletions();
+ if (!pendingTopicDeletions.isEmpty()) {
+ operationConsumer.accept(
+ DELETE_PENDING_TOPIC_DELETION,
+ "Delete pending topic deletions",
+ migrationState ->
migrationClient.topicClient().clearPendingTopicDeletions(pendingTopicDeletions,
migrationState)
Review Comment:
hmm, I think this logic to clear pending topic deletions should exist in the
code to sync kraft state to zk state rather than here, right? I think the other
stuff here just reads and doesn't write (correct?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
