philipnee commented on code in PR #14532:
URL: https://github.com/apache/kafka/pull/14532#discussion_r1364830057


##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/TopicMetadataRequestManagerTest.java:
##########
@@ -151,6 +152,36 @@ void testHardFailures(Exception exception) {
         }
     }
 
+    @Test
+    public void testNetworkTimeout() {

Review Comment:
   Per previous comment: NetworkTimeout isn't handled correctly in the 
commitRequestManager, therefore I want to address this in that PR.  I will 
check other request manager to ensure this is tested.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to