jlprat commented on code in PR #14561:
URL: https://github.com/apache/kafka/pull/14561#discussion_r1363403384
##########
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##########
@@ -253,7 +251,6 @@ private void configureRSM() {
remoteLogStorageManager.configure(rsmProps);
}
- @SuppressWarnings("removal")
RemoteLogMetadataManager createRemoteLogMetadataManager() {
return java.security.AccessController.doPrivileged(new
PrivilegedAction<RemoteLogMetadataManager>() {
private final String classPath =
rlmConfig.remoteLogMetadataManagerClassPath();
Review Comment:
In line 899 (original file) you can find the private method
`deleteLogSegmentsDueToLeaderEpochCacheTruncation` that returns a boolean, but
the boolean is never used. The method can be converted to a `void` one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
