ijuma commented on code in PR #13787:
URL: https://github.com/apache/kafka/pull/13787#discussion_r1362920887
##########
core/src/main/scala/kafka/cluster/Partition.scala:
##########
@@ -1279,7 +1283,7 @@ class Partition(val topicPartition: TopicPartition,
}
def appendRecordsToLeader(records: MemoryRecords, origin: AppendOrigin,
requiredAcks: Int,
- requestLocal: RequestLocal): LogAppendInfo = {
+ requestLocal: RequestLocal, verificationGuard:
Object = null): LogAppendInfo = {
Review Comment:
> I don't think there is an expectation that the string literals would be
different objects, this code allocates new objects to get unique identity.
Right, but the lack of strong typing doesn't prevent the wrong instance from
being passed. That's why we should not use `Object` like that. In practice, it
results in avoidable bugs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
