mjsax commented on code in PR #14550:
URL: https://github.com/apache/kafka/pull/14550#discussion_r1359668981
##########
streams/src/main/java/org/apache/kafka/streams/kstream/ForeachAction.java:
##########
@@ -27,15 +27,18 @@
*
* @param <K> key type
* @param <V> value type
+ *
* @see KStream#foreach(ForeachAction)
*/
public interface ForeachAction<K, V> {
/**
* Perform an action for each record of a stream.
*
- * @param key the key of the record
- * @param value the value of the record
+ * @param key
Review Comment:
It's not necessary but make JavaDocs easier to read in general -- and I like
to have consistent formatting across the board -- would like to establish this
new formatting if nobody objects.
Especially when there is many parameters with name of different length, it
cumbersome to get nice formatting -- adding the description in the next line
avoid all those whitespaces (and if we rename a parameter it becomes a single
line change and no reformatting is necessary)
##########
streams/src/main/java/org/apache/kafka/streams/kstream/Initializer.java:
##########
@@ -16,12 +16,12 @@
*/
package org.apache.kafka.streams.kstream;
-
/**
* The {@code Initializer} interface for creating an initial value in
aggregations.
* {@code Initializer} is used in combination with {@link Aggregator}.
*
- * @param <VA> aggregate value type
+ * @param <VAag> aggregate value type
Review Comment:
Ups.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
