[
https://issues.apache.org/jira/browse/KAFKA-15606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15606:
------------------------------
Description:
As part of the review for [FetchRequestManager pull
request|https://github.com/apache/kafka/pull/14406], [~junrao] had some
questions related to the correctness and clarity of the
{{FetcherTest.testCompletedFetchRemoval()}} test:
Questions:
* https://github.com/apache/kafka/pull/14406#discussion_r1347908197
* https://github.com/apache/kafka/pull/14406#discussion_r1347910980
* https://github.com/apache/kafka/pull/14406#discussion_r1347913781
was:
As part of the review for [pull request
#14406|https://github.com/apache/kafka/pull/14406], [~junrao] made two comments
on the {{FetcherTest.testCompletedFetchRemoval()}} test:
{quote}
Is [the check for the records size of 3] redundant given the test [two lines
above]?[1]
{quote}
And also:
{quote}
Hmm, why don't we return records from other partitions since maxRecords is
maxInt?[2]
{quote}
References:
* [1] https://github.com/apache/kafka/pull/14406#discussion_r1347908197
* [2] https://github.com/apache/kafka/pull/14406#discussion_r1347910980
> Verify & refactor correctness of FetcherTest.testCompletedFetchRemoval()
> ------------------------------------------------------------------------
>
> Key: KAFKA-15606
> URL: https://issues.apache.org/jira/browse/KAFKA-15606
> Project: Kafka
> Issue Type: Improvement
> Components: clients, consumer
> Reporter: Kirk True
> Assignee: Kirk True
> Priority: Major
>
> As part of the review for [FetchRequestManager pull
> request|https://github.com/apache/kafka/pull/14406], [~junrao] had some
> questions related to the correctness and clarity of the
> {{FetcherTest.testCompletedFetchRemoval()}} test:
> Questions:
> * https://github.com/apache/kafka/pull/14406#discussion_r1347908197
> * https://github.com/apache/kafka/pull/14406#discussion_r1347910980
> * https://github.com/apache/kafka/pull/14406#discussion_r1347913781
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
