philipnee commented on code in PR #14532:
URL: https://github.com/apache/kafka/pull/14532#discussion_r1358637014
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -290,7 +290,6 @@ private void onFailure(final long currentTimeMs,
private void retry(final long currentTimeMs) {
onFailedAttempt(currentTimeMs);
- onSendAttempt(currentTimeMs);
Review Comment:
This is duplicated because the manager only sends out the request when it is
being polled via the `poll()` method, which `drain()` the unsent requests from
the queue. In the `drain()` it already invokes the `onSentAttempt()`
See
```
for (OffsetFetchRequestState request : partitionedBySendability.get(true)) {
request.onSendAttempt(currentTimeMs);
unsentRequests.add(request.toUnsentRequest());
inflightOffsetFetches.add(request);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
