ahuang98 commented on code in PR #14206:
URL: https://github.com/apache/kafka/pull/14206#discussion_r1355932210
##########
metadata/src/test/java/org/apache/kafka/metadata/migration/KRaftMigrationDriverTest.java:
##########
@@ -627,10 +629,13 @@ public void testTopicDualWriteDelta() throws Exception {
assertEquals(1, topicClient.deletedTopics.size());
assertEquals("foo", topicClient.deletedTopics.get(0));
- assertEquals(1, topicClient.createdTopics.size());
- assertEquals("baz", topicClient.createdTopics.get(0));
+ assertEquals(2, topicClient.createdTopics.size());
+ assertTrue(topicClient.createdTopics.contains("foo"));
+ assertTrue(topicClient.createdTopics.contains("baz"));
assertTrue(topicClient.updatedTopicPartitions.get("bar").contains(0));
- assertEquals(new ConfigResource(ConfigResource.Type.TOPIC, "foo"),
configClient.deletedResources.get(0));
+ assertEquals(2, configClient.deletedResources.size());
Review Comment:
It's strange that `configClient` tracks two deleted resources while
`topicClient` only sees one.
The only difference between this and the former test seems to be that the
migration driver calls `onMetadataUpdate` on a `LogDeltaManifest` here rather
than a `SnapshotManifest` in the former test.
cc @mumrah not sure if there's a bug here or if I'm missing something
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
