lianetm commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1347885711
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##########
@@ -693,15 +1015,14 @@ private boolean refreshCommittedOffsetsIfNeeded(Timer
timer) {
log.debug("Refreshing committed offsets for partitions {}",
initializingPartitions);
try {
- final Map<TopicPartition, OffsetAndMetadata> offsets =
eventHandler.addAndGet(new OffsetFetchApplicationEvent(initializingPartitions),
timer);
+ final Map<TopicPartition, OffsetAndMetadata> offsets =
applicationEventHandler.addAndGet(new
OffsetFetchApplicationEvent(initializingPartitions), timer);
Review Comment:
I know for sure we skip empty lists and don't send requests for all the
partition offsets related events (on the `OffsetsRequestManager` on
[fetchOffsets](https://github.com/apache/kafka/blob/cdf726fd358f9be3438ceefb01073ab40a31a8b4/clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsRequestManager.java#L151),
[resetPositions](https://github.com/apache/kafka/blob/cdf726fd358f9be3438ceefb01073ab40a31a8b4/clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsRequestManager.java#L193)
and
[validatePositions](https://github.com/apache/kafka/blob/cdf726fd358f9be3438ceefb01073ab40a31a8b4/clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsRequestManager.java#L216)).
That being said, here is about fetching the committed offsets, and I don't
see a clear early return but maybe I'm missing how it happens so let's wait for
@philipnee to give it a closer look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
