mumrah commented on code in PR #14478:
URL: https://github.com/apache/kafka/pull/14478#discussion_r1344679204
##########
metadata/src/main/java/org/apache/kafka/controller/metrics/QuorumControllerMetrics.java:
##########
@@ -160,8 +160,8 @@ public Long value() {
registry.ifPresent(r -> r.newGauge(ZK_WRITE_BEHIND_LAG, new
Gauge<Long>() {
@Override
public Long value() {
- // not in dual-write mode: set metric value to 0
- if (dualWriteOffset() == 0) return 0L;
+ // not in dual-write mode on not an active controller: set
metric value to 0
Review Comment:
nit: typo "on" should be "or"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
