vamossagar12 commented on code in PR #14432:
URL: https://github.com/apache/kafka/pull/14432#discussion_r1335136107
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -929,12 +929,22 @@ private
CoordinatorResult<ConsumerGroupHeartbeatResponseData, Record> consumerGr
ConsumerGroup group = getOrMaybeCreateConsumerGroup(groupId, false);
ConsumerGroupMember member = group.getOrMaybeCreateMember(memberId,
false);
- log.info("[GroupId " + groupId + "] Member " + memberId + " left the
consumer group.");
-
- List<Record> records = consumerGroupFenceMember(group, member);
+ List<Record> records = new ArrayList<>();
+ // The departing member is a static one. We don't need to fence this
member because it is
+ // expected to come back within session timeout
+ if (member.instanceId() != null) {
+ log.info("Member {} with instance id {} is a static member and
will not be fenced from the group", memberId, member.instanceId());
+ } else {
+ log.info("[GroupId {}] Member {} left the consumer group.",
groupId, memberId);
Review Comment:
I have taken the liberty and updated the log line to use an argument based
loggers instead of the string concatenation based pattern that existed before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
