plazma-prizma commented on code in PR #14399:
URL: https://github.com/apache/kafka/pull/14399#discussion_r1331398971
##########
core/src/main/scala/kafka/server/KafkaRequestHandler.scala:
##########
@@ -79,14 +79,17 @@ object KafkaRequestHandler {
/**
* A thread that answers kafka requests.
*/
-class KafkaRequestHandler(id: Int,
- brokerId: Int,
- val aggregateIdleMeter: Meter,
- val totalHandlerThreads: AtomicInteger,
- val requestChannel: RequestChannel,
- apis: ApiRequestHandler,
- time: Time) extends Runnable with Logging {
- this.logIdent = s"[Kafka Request Handler $id on Broker $brokerId], "
+class KafkaRequestHandler(
+ id: Int,
+ brokerId: Int,
+ val aggregateIdleMeter: Meter,
+ val totalHandlerThreads: AtomicInteger,
+ val requestChannel: RequestChannel,
+ apis: ApiRequestHandler,
+ time: Time,
+ nodeName: String = "broker"
Review Comment:
shall we use an enum instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
