kamalcph commented on PR #14407: URL: https://github.com/apache/kafka/pull/14407#issuecomment-1726278190
> I had a comment to fix this/similar problem in original PR - [#13561 (comment)](https://github.com/apache/kafka/pull/13561#discussion_r1293305304) > > I am curious, why didn't the test which was added to resolve the comment fail? Is it because the test only checked for eligibility of a segment for calculation of size and didn't actually check if same segment is being counted twice? We don't have a test for the scenario mentioned in the [comment](https://github.com/apache/kafka/pull/13561#discussion_r1293305304). And, there was a regression after #14349. I have added couple of tests to verify the deleted segment count and log-start-offset. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
