gharris1727 commented on PR #14398: URL: https://github.com/apache/kafka/pull/14398#issuecomment-1725803652
> However, the duplicates introduced in https://github.com/apache/kafka/pull/14089 (that is being fixed here) would be a lot more in number for most installations of Kafka Connect. I'm now on the fence about whether or not this qualifies as a release blocker. Yes, the number of duplicates is much higher and might actually be noticed now. Previously it was really only the dual converter/headerconverters which caused duplicates, and there would just be pairs of them. Now, if i install every public plugin, some are really duplicated a lot: ``` 16 "{\"class\":\"io.confluent.connect.avro.AvroConverter\",\"type\":\"converter\"}" 5 "{\"class\":\"io.confluent.connect.cloud.storage.source.format.ByteArrayConverter\",\"type\":\"converter\"}" 2 "{\"class\":\"io.confluent.connect.jms.JmsSourceConnector\",\"type\":\"source\",\"version\":\"5.5.1\"}" 2 "{\"class\":\"io.confluent.connect.protobuf.ProtobufConverter\",\"type\":\"converter\"}" 13 "{\"class\":\"io.confluent.connect.storage.tools.SchemaSourceConnector\",\"type\":\"source\",\"version\":\"3.6.0\"}" 4 "{\"class\":\"io.debezium.converters.BinaryDataConverter\",\"type\":\"converter\"}" 4 "{\"class\":\"io.debezium.converters.BinaryDataConverter\",\"type\":\"header_converter\"}" 4 "{\"class\":\"io.debezium.converters.ByteArrayConverter\",\"type\":\"converter\"}" 4 "{\"class\":\"io.debezium.converters.ByteArrayConverter\",\"type\":\"header_converter\"}" 6 "{\"class\":\"io.debezium.transforms.ByLogicalTableRouter\",\"type\":\"transformation\"}" 5 "{\"class\":\"io.debezium.transforms.ExtractNewRecordState\",\"type\":\"transformation\"}" 5 "{\"class\":\"io.debezium.transforms.outbox.EventRouter\",\"type\":\"transformation\"}" 5 "{\"class\":\"io.debezium.transforms.tracing.ActivateTracingSpan\",\"type\":\"transformation\"}" 5 "{\"class\":\"org.apache.kafka.connect.storage.SimpleHeaderConverter\",\"type\":\"header_converter\"}" 5 "{\"class\":\"org.apache.kafka.connect.storage.StringConverter\",\"type\":\"converter\"}" 5 "{\"class\":\"org.apache.kafka.connect.storage.StringConverter\",\"type\":\"header_converter\"}" 2 "{\"class\":\"org.apache.kafka.connect.transforms.Cast$Key\",\"type\":\"transformation\"}" 2 "{\"class\":\"org.apache.kafka.connect.transforms.Cast$Value\",\"type\":\"transformation\"}" 2 "{\"class\":\"org.apache.kafka.connect.transforms.ExtractField$Key\",\"type\":\"transformation\"}" 2 "{\"class\":\"org.apache.kafka.connect.transforms.ExtractField$Value\",\"type\":\"transformation\"}" 2 "{\"class\":\"org.apache.kafka.connect.transforms.Filter\",\"type\":\"transformation\"}" 2 "{\"class\":\"org.apache.kafka.connect.transforms.Flatten$Key\",\"type\":\"transformation\"}" 2 "{\"class\":\"org.apache.kafka.connect.transforms.Flatten$Value\",\"type\":\"transformation\"}" 2 "{\"class\":\"org.apache.kafka.connect.transforms.HoistField$Key\",\"type\":\"transformation\"}" 2 "{\"class\":\"org.apache.kafka.connect.transforms.HoistField$Value\",\"type\":\"transformation\"}" 2 "{\"class\":\"org.apache.kafka.connect.transforms.InsertField$Key\",\"type\":\"transformation\"}" 2 "{\"class\":\"org.apache.kafka.connect.transforms.InsertField$Value\",\"type\":\"transformation\"}" 2 "{\"class\":\"org.apache.kafka.connect.transforms.MaskField$Key\",\"type\":\"transformation\"}" 2 "{\"class\":\"org.apache.kafka.connect.transforms.MaskField$Value\",\"type\":\"transformation\"}" 2 "{\"class\":\"org.apache.kafka.connect.transforms.RegexRouter\",\"type\":\"transformation\"}" 2 "{\"class\":\"org.apache.kafka.connect.transforms.ReplaceField$Key\",\"type\":\"transformation\"}" 2 "{\"class\":\"org.apache.kafka.connect.transforms.ReplaceField$Value\",\"type\":\"transformation\"}" 2 "{\"class\":\"org.apache.kafka.connect.transforms.SetSchemaMetadata$Key\",\"type\":\"transformation\"}" 2 "{\"class\":\"org.apache.kafka.connect.transforms.SetSchemaMetadata$Value\",\"type\":\"transformation\"}" 2 "{\"class\":\"org.apache.kafka.connect.transforms.TimestampConverter$Key\",\"type\":\"transformation\"}" 2 "{\"class\":\"org.apache.kafka.connect.transforms.TimestampConverter$Value\",\"type\":\"transformation\"}" 2 "{\"class\":\"org.apache.kafka.connect.transforms.TimestampRouter\",\"type\":\"transformation\"}" 2 "{\"class\":\"org.apache.kafka.connect.transforms.ValueToKey\",\"type\":\"transformation\"}" 2 "{\"class\":\"org.apache.kafka.connect.transforms.predicates.HasHeaderKey\",\"type\":\"predicate\"}" 2 "{\"class\":\"org.apache.kafka.connect.transforms.predicates.RecordIsTombstone\",\"type\":\"predicate\"}" 2 "{\"class\":\"org.apache.kafka.connect.transforms.predicates.TopicNameMatches\",\"type\":\"predicate\"}" ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
