philipnee commented on code in PR #14386:
URL: https://github.com/apache/kafka/pull/14386#discussion_r1325353270
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java:
##########
@@ -203,16 +204,17 @@ public static class UnsentRequest {
private Timer timer;
public UnsentRequest(final AbstractRequest.Builder<?> requestBuilder,
final Optional<Node> node) {
- this(requestBuilder, node, new FutureCompletionHandler());
+ Objects.requireNonNull(requestBuilder);
+ this.requestBuilder = requestBuilder;
+ this.node = node;
+ this.handler = new FutureCompletionHandler();
}
public UnsentRequest(final AbstractRequest.Builder<?> requestBuilder,
final Optional<Node> node,
- final FutureCompletionHandler handler) {
- Objects.requireNonNull(requestBuilder);
- this.requestBuilder = requestBuilder;
- this.node = node;
- this.handler = handler;
+ final BiConsumer<ClientResponse, Throwable>
callback) {
Review Comment:
I think it is according to my IDE. I think it is used in
CommitRequestManager (line 219 and 256) and TopicMetadataRequestManger (line
145)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
