kamalcph commented on PR #14243: URL: https://github.com/apache/kafka/pull/14243#issuecomment-1716914049
> > @hudeqi > > Can you rebase your branch against trunk instead of merge? With rebase, we can review the changes easily. > > Do you mean to merge these temporary commits into one commit? @kamalcph No, not squashing the commits. If you rebase your branch with trunk, then all your commits will be on the top of the tree which will be easy for the reviewers to review the change-set and follow the comments posted on this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
