showuon commented on PR #14373:
URL: https://github.com/apache/kafka/pull/14373#issuecomment-1715543328

   > The behaviour is same in our internal branch. While moving the code, I 
missed it. Thanks for fixing it! I've invited you as collaborator to my branch. 
You can overlay this change on top of 
https://github.com/apache/kafka/pull/14347, so that all the tests can be 
verified in one PR. Added you as the co-author of 
https://github.com/apache/kafka/pull/14347.
   
   That's great! But I'd prefer separate these changes as a separate PR since 
https://github.com/apache/kafka/pull/14347 had completed reviewed and got 3 
approvals. We should keep it as is and merge it first, then have a new review 
in this PR. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to