kamalcph commented on PR #14349: URL: https://github.com/apache/kafka/pull/14349#issuecomment-1709408592
@divijvaidya Could you please review this patch? Discussion [thread](https://github.com/apache/kafka/pull/13561#discussion_r1226538752): This patch addresses the case-2 mentioned in the KAFKA-15352 ticket partially. Only the leader will move the log-start-offset and starts to delete the remote log segments. In middle of deleting the remote log segments, if leader switch happens then there can be two cases: 1. The log-start-offset changes was propagated to all the replicas including the new-leader. In this case, both the old-leader and new-leader can delete the remote log segments since the log-start-offset can be updated only with the monotonically increasing value. 2. The log-start-offset changes was not propagated to the new leader. In this case, the new leader assumes the log-start-offset which can be deleted immediately by the old leader and the log-start-offset can be stale until the next segment deletion, we can address this case by ensuring that the log-start-offset propagates to all the replicas before deleting the remote log segments, we can take this up later (or) file a JIRA. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
