kamalcph commented on code in PR #14285:
URL: https://github.com/apache/kafka/pull/14285#discussion_r1305437640
##########
core/src/test/scala/integration/kafka/admin/RemoteTopicCrudTest.scala:
##########
@@ -365,12 +363,11 @@ object MyRemoteStorageManager {
val deleteSegmentEventCounter = new AtomicInteger(0)
}
-class MyRemoteStorageManager extends NoOpRemoteStorageManager with Logging {
+class MyRemoteStorageManager extends NoOpRemoteStorageManager {
import MyRemoteStorageManager._
override def deleteLogSegmentData(remoteLogSegmentMetadata:
RemoteLogSegmentMetadata): Unit = {
deleteSegmentEventCounter.incrementAndGet()
- info(s"Deleted the remote log segment: $remoteLogSegmentMetadata, counter:
${deleteSegmentEventCounter.get()}")
Review Comment:
Previously, we were checking it manually by counting the number of log
statements. Fixed the test by adding an assertion which validates the number of
deleted segments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
