Nickstery commented on code in PR #14104:
URL: https://github.com/apache/kafka/pull/14104#discussion_r1302658841
##########
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##########
@@ -478,23 +498,45 @@ void testMetricsUpdateOnCopyLogSegmentsFailure() throws
Exception {
when(fileRecords.sizeInBytes()).thenReturn(10);
when(oldSegment.readNextOffset()).thenReturn(nextSegmentStartOffset);
- when(mockLog.activeSegment()).thenReturn(activeSegment);
- when(mockLog.logStartOffset()).thenReturn(oldSegmentStartOffset);
- when(mockLog.logSegments(anyLong(),
anyLong())).thenReturn(JavaConverters.collectionAsScalaIterable(Arrays.asList(oldSegment,
activeSegment)));
-
- ProducerStateManager mockStateManager =
mock(ProducerStateManager.class);
- when(mockLog.producerStateManager()).thenReturn(mockStateManager);
-
when(mockStateManager.fetchSnapshot(anyLong())).thenReturn(Optional.of(mockProducerSnapshotIndex));
- when(mockLog.lastStableOffset()).thenReturn(250L);
-
LazyIndex idx =
LazyIndex.forOffset(UnifiedLog.offsetIndexFile(tempDir, oldSegmentStartOffset,
""), oldSegmentStartOffset, 1000);
LazyIndex timeIdx =
LazyIndex.forTime(UnifiedLog.timeIndexFile(tempDir, oldSegmentStartOffset, ""),
oldSegmentStartOffset, 1500);
File txnFile = UnifiedLog.transactionIndexFile(tempDir,
oldSegmentStartOffset, "");
txnFile.createNewFile();
TransactionIndex txnIndex = new
TransactionIndex(oldSegmentStartOffset, txnFile);
+
when(oldSegment.lazyTimeIndex()).thenReturn(timeIdx);
+ when(oldSegment.timeIndex()).thenReturn(new
TimeIndex(TestUtils.tempFile(), baseOffset, maxEntries * 12));
when(oldSegment.lazyOffsetIndex()).thenReturn(idx);
when(oldSegment.txnIndex()).thenReturn(txnIndex);
+ when(oldSegment.offsetIndex()).thenReturn(new
OffsetIndex(TestUtils.tempFile(),
+ oldSegmentStartOffset, maxEntries * 8));
+
+ LazyIndex idx2 =
LazyIndex.forOffset(UnifiedLog.offsetIndexFile(tempDir, nextSegmentStartOffset,
""), nextSegmentStartOffset, 1000);
+ LazyIndex timeIdx2 =
LazyIndex.forTime(UnifiedLog.timeIndexFile(tempDir, nextSegmentStartOffset,
""), nextSegmentStartOffset, 1500);
+
+ txnFile.createNewFile();
+
+ when(activeSegment.lazyTimeIndex()).thenReturn(timeIdx2);
+ when(activeSegment.lazyOffsetIndex()).thenReturn(idx2);
+ when(activeSegment.timeIndex()).thenReturn(new
TimeIndex(TestUtils.tempFile(), baseOffset, maxEntries * 12));
+ when(activeSegment.txnIndex()).thenReturn(new
TransactionIndex(nextSegmentStartOffset, txnFile));
+ when(activeSegment.offsetIndex()).thenReturn(new
OffsetIndex(TestUtils.tempFile(),
+ nextSegmentStartOffset, maxEntries * 8));
+
+ when(mockLog.activeSegment()).thenReturn(activeSegment);
+
+ when(mockLog.logSegments(anyLong(),
anyLong())).thenReturn(JavaConverters.collectionAsScalaIterable(Arrays.asList(oldSegment,
activeSegment)));
+
+ ProducerStateManager mockStateManager =
mock(ProducerStateManager.class);
+ when(mockLog.producerStateManager()).thenReturn(mockStateManager);
+
when(mockStateManager.fetchSnapshot(anyLong())).thenReturn(Optional.of(mockProducerSnapshotIndex));
+ when(mockLog.lastStableOffset()).thenReturn(250L);
+
+
+ when(mockLog.activeSegment()).thenReturn(activeSegment);
+ when(mockLog.logStartOffset()).thenReturn(oldSegmentStartOffset);
+ when(mockLog.logSegments(anyLong(),
anyLong())).thenReturn(JavaConverters.collectionAsScalaIterable(Arrays.asList(oldSegment,
activeSegment)));
+ when(mockLog.lastStableOffset()).thenReturn(250L);
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
