divijvaidya commented on code in PR #14204:
URL: https://github.com/apache/kafka/pull/14204#discussion_r1295503005
##########
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableTransformValuesTest.java:
##########
@@ -163,104 +159,74 @@ public void shouldNotSendOldValuesByDefault() {
final Processor<String, Change<String>, String, Change<String>>
processor = transformValues.get();
processor.init(context);
- context.forward(new Record<>("Key", new Change<>("Key->newValue!",
null), 0));
- expectLastCall();
- replay(context);
+ doNothing().when(context).forward(new Record<>("Key", new
Change<>("Key->newValue!", null), 0));
processor.process(new Record<>("Key", new Change<>("newValue",
"oldValue"), 0));
-
- verify(context);
}
@Test
public void shouldSendOldValuesIfConfigured() {
final KTableTransformValues<String, String, String> transformValues =
new KTableTransformValues<>(parent, new
ExclamationValueTransformerSupplier(), null);
- expect(parent.enableSendingOldValues(true)).andReturn(true);
- replay(parent);
+ when(parent.enableSendingOldValues(true)).thenReturn(true);
transformValues.enableSendingOldValues(true);
final Processor<String, Change<String>, String, Change<String>>
processor = transformValues.get();
processor.init(context);
- context.forward(new Record<>("Key", new Change<>("Key->newValue!",
"Key->oldValue!"), 0));
- expectLastCall();
- replay(context);
+ doNothing().when(context).forward(new Record<>("Key", new
Change<>("Key->newValue!", "Key->oldValue!"), 0));
processor.process(new Record<>("Key", new Change<>("newValue",
"oldValue"), 0));
-
- verify(context);
- }
-
- @Test
- public void shouldNotSetSendOldValuesOnParentIfMaterialized() {
Review Comment:
Correct me if I am wrong here but this test validates that code never
executes:
```
if (parent.enableSendingOldValues(forceMaterialization)) {
sendOldValues = true;
}
```
in `enableSendingOldValues()`. The way how this test does it is by throwing
an exception on it's call and if the code executes, the exception will be
thrown and test will fail.
You can change it by explicitly verifying that no calls to
`parent.enableSendingOldValues` is made in this code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
