kamalcph commented on code in PR #13947:
URL: https://github.com/apache/kafka/pull/13947#discussion_r1293498028
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##########
@@ -421,6 +425,7 @@ public void close() {
// Initiate shutdown for cleaning thread
boolean shutdownRequired = cleanerThread.initiateShutdown();
// Close all the opened indexes to force unload mmap memory.
This does not delete the index files from disk.
+ internalCache.cleanUp();
Review Comment:
@divijvaidya
I don't understand the below comment. Could you please explain? Is it OK to
do cleanup before closing the cache otherwise the newly added tests are
failing? (testRemoveItem and testRemoveNonExistentItem) Thanks!
> // Note that internal cache does not require explicit cleaning/closing. We
don't want to invalidate or cleanup
// the cache as both would lead to triggering of removal
listener.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
