mjsax commented on code in PR #14164:
URL: https://github.com/apache/kafka/pull/14164#discussion_r1287692186
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/AssignmentTestUtils.java:
##########
@@ -587,14 +587,18 @@ static List<Node> getRandomNodes(final int nodeSize) {
return nodeList;
}
+ static Node[] getRandomReplica(final List<Node> nodeList, final int index)
{
Review Comment:
Does not seem to be random actually?
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/AssignmentTestUtils.java:
##########
@@ -587,14 +587,18 @@ static List<Node> getRandomNodes(final int nodeSize) {
return nodeList;
}
+ static Node[] getRandomReplica(final List<Node> nodeList, final int index)
{
Review Comment:
Does not seem to be random actually?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
