kamalcph commented on code in PR #14049: URL: https://github.com/apache/kafka/pull/14049#discussion_r1276098707
########## storage/api/src/test/java/org/apache/kafka/server/log/remote/storage/NoOpRemoteLogMetadataManager.java: ########## @@ -74,6 +74,11 @@ public void onPartitionLeadershipChanges(Set<TopicIdPartition> leaderPartitions, public void onStopPartitions(Set<TopicIdPartition> partitions) { } + @Override + public long remoteLogSize(TopicIdPartition topicPartition, int leaderEpoch) { Review Comment: can we use same variable name? topicPartition -> topicIdPartition ########## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ClassLoaderAwareRemoteLogMetadataManager.java: ########## @@ -101,6 +101,11 @@ public void onStopPartitions(Set<TopicIdPartition> partitions) { }); } + @Override + public long remoteLogSize(TopicIdPartition topicPartition, int leaderEpoch) throws RemoteStorageException { Review Comment: ditto -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org