C0urante commented on code in PR #13801:
URL: https://github.com/apache/kafka/pull/13801#discussion_r1275098764
##########
connect/runtime/src/test/java/org/apache/kafka/connect/storage/OffsetStorageWriterTest.java:
##########
@@ -192,6 +197,220 @@ public void testCancelAfterAwaitFlush() throws Exception {
flushFuture.get(1000, TimeUnit.MILLISECONDS);
}
+ @Test
Review Comment:
Sorry, the point isn't just that we should have a new test suite with the
same exact tests in it, it's that we should be testing the semantics of the
`ConnectorOffsetBackingStore` class directly. We shouldn't be creating
`OffsetStorageWriter` instances in these tests, we should be invoking, e.g.,
`ConnectorOffsetBackingStore::set` directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
