rreddy-22 commented on code in PR #13998:
URL: https://github.com/apache/kafka/pull/13998#discussion_r1272557652
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java:
##########
@@ -244,16 +244,21 @@ public TargetAssignmentResult build() throws
PartitionAssignorException {
});
// Prepare the topic metadata.
- Map<Uuid, AssignmentTopicMetadata> topics = new HashMap<>();
+ Map<Uuid, PartitionMetadata> topicMetadataMap = new HashMap<>();
subscriptionMetadata.forEach((topicName, topicMetadata) ->
- topics.put(topicMetadata.id(), new
AssignmentTopicMetadata(topicMetadata.numPartitions()))
+ topicMetadataMap.put(
+ topicMetadata.id(),
+ new PartitionMetadata(topicMetadata.partitionRacks())
Review Comment:
Let me create a Uuid -> PartitionMetadata map in TopicMetadata itself and
then pass it directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
