rreddy-22 commented on code in PR #13998:
URL: https://github.com/apache/kafka/pull/13998#discussion_r1269946491
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/PartitionAssignor.java:
##########
@@ -36,8 +36,9 @@ public interface PartitionAssignor {
* Perform the group assignment given the current members and
* topic metadata.
*
- * @param assignmentSpec The assignment spec.
+ * @param assignmentTopicDescriber The topic and cluster metadata
describer {@link AssignmentTopicDescriber}.
+ * @param assignmentSpec The member assignment spec.
* @return The new assignment for the group.
*/
- GroupAssignment assign(AssignmentSpec assignmentSpec) throws
PartitionAssignorException;
+ GroupAssignment assign(AssignmentTopicDescriber assignmentTopicDescriber,
AssignmentSpec assignmentSpec) throws PartitionAssignorException;
Review Comment:
The order prolly doesn't matter too much but yeah changed it just cause of
the names the order you suggested makes sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
