philipnee commented on code in PR #13797:
URL: https://github.com/apache/kafka/pull/13797#discussion_r1265949795
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##########
@@ -106,4 +114,17 @@ private boolean process(final OffsetFetchApplicationEvent
event) {
manager.addOffsetFetchRequest(event.partitions);
return true;
}
+
+ private boolean process(final NewTopicsMetadataUpdateRequestEvent event) {
+ metadata.requestUpdateForNewTopics();
+ return true;
+ }
+
+ private boolean process(final AssignmentChangeApplicationEvent event) {
+ Optional<RequestManager> commitRequestManger =
registry.get(RequestManager.Type.COMMIT);
+ CommitRequestManager manager = (CommitRequestManager)
commitRequestManger.get();
Review Comment:
FWIW: I think currently, group.id can be null as well as an empty string.
Only when the group id is null, the coordinator object won't be created. We
are planning to drop the support of empty string soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
