jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1263905173
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -247,31 +324,78 @@ GroupMetadataManager build() {
*/
private MetadataImage metadataImage;
+ /**
+ * An empty result returned to the state machine. This means that
+ * there are no records to append to the log.
+ *
+ * Package private for testing.
+ */
+ static final CoordinatorResult<Void, Record> EMPTY_RESULT =
+ new CoordinatorResult<>(Collections.emptyList(),
CompletableFuture.completedFuture(null));
Review Comment:
that forces the CoordinatorResult class to become non-generic which i don't
think we want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
