gharris1727 commented on PR #13853: URL: https://github.com/apache/kafka/pull/13853#issuecomment-1632939211
Hey @daehokimm Thanks for the PR! I think that there is some semantic difference between `AbstractStatus.State` and `ConnectorStatus.State`, and certainly between `ConnectorStatus.State` and `TaskStatus.State`. Unfortunately Java doesn't seem to think so: there's no difference in the type-checker to separate these different types. Without the type-checker to enforce this, I don't think we're going to catch all of the mistakes that already exist, or prevent new ones from being added. What do you think about refactoring this AbstractStatus.State into distinct enums? It would help us to find all of the other places that this typo may exist. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
