hudeqi commented on code in PR #13959:
URL: https://github.com/apache/kafka/pull/13959#discussion_r1254636348
##########
core/src/main/scala/kafka/controller/KafkaController.scala:
##########
@@ -537,6 +537,7 @@ class KafkaController(val config: KafkaConfig,
private def removeMetrics(): Unit = {
KafkaController.MetricNames.foreach(metricsGroup.removeMetric)
+ controllerChannelManager.removeMetrics()
Review Comment:
Since the current ControllerChannelManager only removes the tagged metrics
(that is, gaugeMetricNameWithTag and timerMetricNameWithTag) of all brokers in
brokerStateInfo during shutdown, but omits TotalQueueSizeMetricName, I added
the removeMetrics method to remove it during broker shutdown. Do you mean to
combine the two into the shutdown method of ControllerChannelManager?
@divijvaidya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
