gharris1727 commented on PR #13821: URL: https://github.com/apache/kafka/pull/13821#issuecomment-1622714371
@C0urante Thanks for the helpful comments! The initial version was just-enough to get later stuff working, but the latest version is a much more complete refactor. > We also still need to either add tests for the service loader scanner, or remove that class from this PR. To properly test the ServiceLoaderScanner, I'll need to add manifests to the TestPlugins. To avoid scope creep, I've moved the ServiceLoaderScanner out of this PR. I'll add it in a follow-up along with the necessary test changes. This is ready for another pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
