jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1253522689
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##########
@@ -578,4 +619,19 @@ public void shutdown() {
Utils.closeQuietly(runtime, "coordinator runtime");
log.info("Shutdown complete.");
}
+
+ private boolean isValidGroupId(String groupId, ApiKeys api) {
+ if (api == ApiKeys.OFFSET_COMMIT ||
+ api == ApiKeys.OFFSET_FETCH ||
+ api == ApiKeys.DESCRIBE_GROUPS ||
+ api == ApiKeys.DELETE_GROUPS
Review Comment:
i will take your suggestion for this PR. however, it does make more sense to
have the logic in one place instead of using isGroupIdNotNull/isGroupIdNotEmpty
based on the request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
